sync: fix missing policy annotations#1446
Merged
Merged
Conversation
The allow_public_unauthenticated_access and allow_any_authenticated_user annotations are not honored by the current unified API sync logic. These are part of the "Base" annotations rather than the "Policy" annotations, but they should still affect the derived policy. Make sure the conversion logic accounts for these annotations.
calebdoxsey
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
allow_public_unauthenticated_accessandallow_any_authenticated_userannotations are not honored by the current unified API sync logic. These are part of the "Base" annotations rather than the "Policy" annotations, but they should still affect the derived policy. Make sure the conversion logic accounts for these annotations.Related issues
https://linear.app/pomerium/issue/ENG-4147/ingress-controller-api-sync-ignores-allow-public-unauthenticated
Checklist
improvement/bug/ etc)